Change in flashrom[master]: Add unit test to run init/shutdown for enabled drivers - flashrom-gerrit

6 Apr 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: Add unit test to run init/shutdown for enabled drivers
......................................................................
Patch Set 2:
(1 comment)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/a53c9af2_45ee2cc8 
PS1, Line 115: #endif /* UNIT_TEST_ENV */
...
I guess we could have something like a `hwaccess_unittest.h`, yes. It could be […]
Great, thank you so much! I took the first half of your advice, very useful.
For the second half, maybe I don't need it yet, but potentially may use it later.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 06:50:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment