Change in flashrom[staging]: 4BA: Flashrom integration for the 4-bytes addressing extensions

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20505 )

Change subject: 4BA: Flashrom integration for the 4-bytes addressing extensions
......................................................................

Patch Set 3:
> Will write a follow-up, not sure if any line will stay.

Nope, I won't. After reading through all the patches I'm failing to
see the light at the end of the tunnel. IMO, this adds 4BA as an alien
instead of integrating it where plausible.

Doing the whole thing with proper abstractions from the beginning (the
function pointer issue + the 10 times copied implementations with
felt only single bytes changing) seems to be less work for me now than
bringing these patches to a state I could imagine they would have after
a decent reviewing process.

Any thoughts where to go from here? I can start over reviewing the
whole set if somebody wants to adapt these commits.

Alternatively we can submit this to staging (I don't see anything
broken, it's just leaving flashrom in a less maintainable state*).
And I can write my own implementation for stable...

* We already have way too much redundant code and layering violations,
  IMHO. If we increase that maintenance burden we'll have to pay
  double later during development and reviewing.