[S] Change in flashrom[main]: erasure_layout: Remove redundant verifications from `erase_write`

[Carly Zlabek (Code Review)]

Attention is currently required from: Aarya, Carly Zlabek, Vincent Fazio.

Hello Aarya, Anastasia Klimchuk, Vincent Fazio, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/79354?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)

Change subject: erasure_layout: Remove redundant verifications from `erase_write`
......................................................................

erasure_layout: Remove redundant verifications from `erase_write`

Previously, in the worst-case scenario of erasing region content then
writing new data, three rounds of verification were performed inside of
the `erase_write` function through calls to:

1. `check_erased_range` when erasing with respect to region boundaries
  2. `check_erased_range` for the entire erase block after the loop
     containing verification 1 completed
  3. `verify_range` when all erases/writes were complete

Verification 2 duplicated verification 1 and was orphaned by commit
fa8808595a, which dropped its paired erasefn call but missed this
related step.

Verification 3 duplicated verification which occurs in
`flashrom_image_write` based on `flashctx flags`.

Now, these 2 redundant verifications are removed to improve the
performance of `erase_write`.

This change was tested using the linux_spi programmer to erase and write
to an MT25QL512 chip.

Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5
Signed-off-by: Carly Zlabek 
Signed-off-by: Vincent Fazio 
---
M erasure_layout.c
1 file changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/79354/2