Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63487 )
Change subject: hwaccess: use __asm__ as it is done elsewhere
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
IIRC, we discussed this change earlier already. I wanted to stall
it until a release (which didn't happen, and we don't seem closer).
We do more build-testing now, so I guess it's ok (to try).
This was also the or one of the things that held us back from
setting a `--std=cxx`.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63487
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I834fa6e171d2b20e1a5faa5a2e8f54caf107171a
Gerrit-Change-Number: 63487
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Mon, 11 Apr 2022 11:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment