Attention is currently required from: Nico Huber, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel ......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/d1c82fc5_d5da20ff PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
The internal programmer should fail at runtime at internal. […]
processor_flash_enable() is only called after try_mtd() on line 255, which will skip the rest of the function if MTD works. It looks like MTD support landed sometime after the change that was meant to disable the internal programmer on other platforms, but this mark_unsupported only works as expected if CONFIG_INTERNAL is explicitly set.
CONFIG_INTERNAL is defaulted to yes further down the file, so it looks like the internal programmer can still be built as long as it's not explicitly enabled even with this change. I'm guessing nobody noticed that this conflicted with the MTD support because this disablement didn't work, with the end result that this mark_unsupported is now incorrect because internal is meant to work on other platforms when MTD is available.
-
Peter Marheine (Code Review)