Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21702 )
Change subject: nicintel_eeprom: Move variable declarations out of loops ......................................................................
Patch Set 1:
We do not (want to) support non-C99 compilers and I seriously
doubt
that this is really the issue and thus the best fix. Can you
please
show us the compiler's diagnostics and build_details.txt?
Well, we kept the code compatible until now and as long as we don't specify the standard, should keep it that way.
No, we didn't at all. Why do you think so? Not *forcing* a version in the makefile does not mean we support *every* compiler out there. We use lots of C99 features all around the code base... including variable declarations in for heads. The report (and patch) are lacking details...
-
Stefan Tauner (Code Review)