Attention is currently required from: Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66672 )
Change subject: chipset_enable.c: Change doit() enable_flash_\S() signatures
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66672/comment/99875144_25b83aa9
PS7, Line 16: Both, get_flashbase_sc520() and via_no_byte_merge()
: should be renamed for consistency.
Doesn't have much to do with the rest of the commit. I would remove it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66672
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I62c5d49a83ed4afb86ac3f0fae56defa1338ab4f
Gerrit-Change-Number: 66672
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sat, 03 Sep 2022 02:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment