Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Anastasia Klimchuk, Peter Marheine.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions
......................................................................
Patch Set 4:
(2 comments)
File doc/conf.py:
https://review.coreboot.org/c/flashrom/+/73359/comment/be37c46c_89383e4d
PS4, Line 27: todo_include_todos = False
The name of this option isn't clear enough, so how about adding a comment before it (taken from sphinx docs):
```
# If true, `todo` and `todolist` produce output, else they produce nothing.
```
File doc/index.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/91b5ca3f_5a1cfe98
PS4, Line 7: :glob:
As far as I understand, it's used for globbing. But there's no wildcard pattern.. did I miss something?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 08 Mar 2023 13:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment