Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69196 )
Change subject: layout: Factor out flash_region structure from romentry ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69196/comment/ecc39154_98116e33 PS6, Line 16: TEST=builds
Have you done any testing with layouts that have multiple regions?
Yes, tested across the lab.
Patchset:
PS2:
I agree commit message needs more info on why the patch exist, one more paragraph would be great, so […]
bug number is irrelevant here. The commit message does describe what is being done here and is supported on its own merits - untangle abstract data structures from the data being stored in them - which is exactly described in the commit message. I added it into the `csme_protected_regions` topic and it is in the relevant chain as well.
-
Edward O'Callaghan (Code Review)