Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/84826?usp=email )
Change subject: writeprotect: Fix inaccurate return code ......................................................................
writeprotect: Fix inaccurate return code
If hardware protection is requested but not supported by the flash chip, return an error code indicating that the protection mode is unsupported, rather than indicating that all WP features are unsupported.
TEST=ninja test
Change-Id: I29e9069c7781fbb238f30aa9a9285b692b0c7200 Signed-off-by: Nikolai Artemiev nartemiev@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/84826 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org --- M writeprotect.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/writeprotect.c b/writeprotect.c index 411089d..964c311 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -482,7 +482,7 @@
case FLASHROM_WP_MODE_HARDWARE: if (!bits->srp_bit_present) - return FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + return FLASHROM_WP_ERR_MODE_UNSUPPORTED;
bits->srl = 0; bits->srp = 1;