Attention is currently required from: Angel Pons, Peter Marheine.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 )
Change subject: CHROMIUM: flashrom_tester: Remove --ignore-fmap option
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52890/comment/701134a2_9a123a50
PS1, Line 7: cli_classic.c
This file is not changed
Done
https://review.coreboot.org/c/flashrom/+/52890/comment/4118f9f8_dd41a6f4
PS1, Line 11: implicetely
typo: implicitly
Done
Patchset:
PS1:
Yeah, I don't know if there's any relevant convention or guideline. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 05 May 2021 14:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Daniel Campello
campello@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment