Attention is currently required from: Thomas Heijligen, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: [WIP] doc: Add build instructions ......................................................................
Patch Set 1:
(5 comments)
File doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/e51260ef_adf4cc06 PS1, Line 32: build If this is a builddir (I think it is), then let's name it builddir. The reason is that `build` looks like a command, can be confusing. I would prefer the name which indicates a directory.
And I just discovered, it is called builddir below! :)
https://review.coreboot.org/c/flashrom/+/73359/comment/5413952f_c8b2355a PS1, Line 174: ross ross -> cross (typo)
https://review.coreboot.org/c/flashrom/+/73359/comment/9bee4446_2cd5bdca PS1, Line 192: If you are not happy with the initial configuration, e.g. a programmer is missing, : or you want to review it If you want to change your initial configuration for some reason (for example you discovered that a programmer is missing), run::
(In your initial text, I am not sure what did you mean by "you want to review it"? the command changes the config, not just prints it?)
https://review.coreboot.org/c/flashrom/+/73359/comment/cd39e1dd_42a25cc3 PS1, Line 206: To get a code coverage report For coverage report: let's keep the existing instructions, please! They more detailed, written recently so they are up-to-date. I don't want to lose that piece of wisdom.
File doc/conf.py:
https://review.coreboot.org/c/flashrom/+/73359/comment/9d543edc_6b58441a PS1, Line 22: 'sphinx.ext.todo' This is a cool feature! :)
-
Anastasia Klimchuk (Code Review)