Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk.
Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email )
Change subject: ichspi: Add RaptorPoint PCH support
......................................................................
Patch Set 5:
(2 comments)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/83854/comment/83335f3a_2ad8227f?usp... :
PS4, Line 2209: {0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600},
: {0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600},
: {0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600}
The chipsets ending with 'E' are IoT SKUs. […]
Added info to the commit message
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/83854/comment/a7ac837b_922aca27?usp... :
PS3, Line 142: "\t- "600" or "alder" for Intel's 600 series chipsets.\n"
Oh sorry, I said it in a confusing way! No, you don't need to add the output of the tool to commit m […]
Got it, added info to the commit message that ich_descriptors_tool has also been tested
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83854?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef
Gerrit-Change-Number: 83854
Gerrit-PatchSet: 5
Gerrit-Owner: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Filip Gołaś
filip.golas@3mdeb.com
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 05 Sep 2024 09:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org