Attention is currently required from: Anastasia Klimchuk, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68179 )
Change subject: flash.h: extend `struct tested` with .wp field
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68179/comment/fd560a32_58c17f85
PS2, Line 11: systems, that also prevents running commands.
Changed to B, I like it more than X.
Nice, thank you! :)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68179/comment/5d0041f2_1e582e51
PS3, Line 11: TICKET
Is this a convention that I missed? Why not the common tag form with
a colon, i.e. `Ticket: `?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68179
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4
Gerrit-Change-Number: 68179
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 13 Oct 2022 12:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment