[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
Attention is currently required from: Felix Singer, Shreeyash . Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (2 comments) Patchset: PS2:
Yes... I can't seem to understand the next step? […] This patch addresses the symptoms of two issues. One, with the libusb_context, was caused by a wrong use of the libusb api. This part I've fixed. The second part, the libusb_device_handle, is an false positive of the analyzers. It is still open and now handled by multiple open patches.
I'm sorry if this was not clear. File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/b75aaa93_5514ef4b PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
So I think this is a false positive. […] Sorry, this has gone under. But it's important to make clear that the NULL is for a false positive in the analyser not a big in flashrom
-- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Felix Singer <felixsinger@posteo.net> Gerrit-Attention: Shreeyash <shreeyash335@gmail.com> Gerrit-Comment-Date: Sat, 01 Oct 2022 20:29:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Comment-In-Reply-To: Thomas Heijligen <src@posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Thomas Heijligen (Code Review)