[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
Attention is currently required from: Felix Singer, Shreeyash .
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Yes... I can't seem to understand the next step? […]
This patch addresses the symptoms of two issues. One, with the libusb_context, was caused by a wrong use of the libusb api. This part I've fixed. The second part, the libusb_device_handle, is an false positive of the analyzers. It is still open and now handled by multiple open patches.
I'm sorry if this was not clear.
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/b75aaa93_5514ef4b PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
So I think this is a false positive. […]
Sorry, this has gone under. But it's important to make clear that the NULL is for a false positive in the analyser not a big in flashrom
-
Thomas Heijligen (Code Review)