Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33256
Change subject: ich_descriptors: Drop line numbering comments ......................................................................
ich_descriptors: Drop line numbering comments
Change-Id: Ia895e35edfc86b6955395c4570d67477da70e2c7 Signed-off-by: Nico Huber nico.h@gmx.de --- M ich_descriptors.c 1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/33256/1
diff --git a/ich_descriptors.c b/ich_descriptors.c index 944af4c..251f636 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -214,23 +214,23 @@ static const char *pprint_freq(enum ich_chipset cs, uint8_t value) { static const char *const freq_str[2][8] = { { - "20 MHz", /* 000 */ - "33 MHz", /* 001 */ - "reserved", /* 010 */ - "reserved", /* 011 */ - "50 MHz", /* 100 */ /* New since Ibex Peak */ - "reserved", /* 101 */ - "reserved", /* 110 */ - "reserved" /* 111 */ + "20 MHz", + "33 MHz", + "reserved", + "reserved", + "50 MHz", /* New since Ibex Peak */ + "reserved", + "reserved", + "reserved" }, { - "reserved", /* 000 */ - "reserved", /* 001 */ - "48 MHz", /* 010 */ - "reserved", /* 011 */ - "30 MHz", /* 100 */ - "reserved", /* 101 */ - "17 MHz", /* 110 */ - "reserved" /* 111 */ + "reserved", + "reserved", + "48 MHz", + "reserved", + "30 MHz", + "reserved", + "17 MHz", + "reserved" } };
switch (cs) {
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33256 )
Change subject: ich_descriptors: Drop line numbering comments ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33256 )
Change subject: ich_descriptors: Drop line numbering comments ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33256 )
Change subject: ich_descriptors: Drop line numbering comments ......................................................................
ich_descriptors: Drop line numbering comments
Change-Id: Ia895e35edfc86b6955395c4570d67477da70e2c7 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/flashrom/+/33256 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M ich_descriptors.c 1 file changed, 16 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/ich_descriptors.c b/ich_descriptors.c index 944af4c..251f636 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -214,23 +214,23 @@ static const char *pprint_freq(enum ich_chipset cs, uint8_t value) { static const char *const freq_str[2][8] = { { - "20 MHz", /* 000 */ - "33 MHz", /* 001 */ - "reserved", /* 010 */ - "reserved", /* 011 */ - "50 MHz", /* 100 */ /* New since Ibex Peak */ - "reserved", /* 101 */ - "reserved", /* 110 */ - "reserved" /* 111 */ + "20 MHz", + "33 MHz", + "reserved", + "reserved", + "50 MHz", /* New since Ibex Peak */ + "reserved", + "reserved", + "reserved" }, { - "reserved", /* 000 */ - "reserved", /* 001 */ - "48 MHz", /* 010 */ - "reserved", /* 011 */ - "30 MHz", /* 100 */ - "reserved", /* 101 */ - "17 MHz", /* 110 */ - "reserved" /* 111 */ + "reserved", + "reserved", + "48 MHz", + "reserved", + "30 MHz", + "reserved", + "17 MHz", + "reserved" } };
switch (cs) {
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)