Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57942 )
Change subject: internal.c: unify the macro for x86 only code ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57942/comment/1c6b9576_0f89b1b2 PS1, Line 9: #if defined(__i386__) || defined(__x86_64__)
nit: To avoid having to escape the `#`, how about: […]
Done
https://review.coreboot.org/c/flashrom/+/57942/comment/aae6dbc1_4416dfc9 PS1, Line 11: platfrom
typo: `platform`
Done
https://review.coreboot.org/c/flashrom/+/57942/comment/c482cfb8_dcc1393c PS1, Line 11: uses
plural: `use`
Done
Patchset:
PS1:
I'd personally use the IS_X86 macro everywhere for consistency, but I don't have a strong preference […]
I'd looked for the most widespread variant for x86 only code. Beside that it's now easier to make changes in platform.h and hwaccess which I want to do
-
Thomas Heijligen (Code Review)