Nico Huber has posted comments on this change. ( https://review.coreboot.org/23700 )
Change subject: flashchips: Add Winbond W25P80/16/32 support
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/23700/2/flashchips.h
File flashchips.h:
https://review.coreboot.org/#/c/23700/2/flashchips.h@916
PS2, Line 916: #define WINBOND_NEX_W25P32 0x2016
Should be placed above, i.e. keep sorted by id?
--
To view, visit
https://review.coreboot.org/23700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b
Gerrit-Change-Number: 23700
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Feb 2018 13:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes