Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )

Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4:
> > Knowing the mainboard avoids running the code on the wrong board where it's more likely to do harm. It's not about the flashing process, flash contents or the contents to be flashed. The code starts with `ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS)`. There may be EC firmware that reacts badly to such a write (or chips that completely misunderstand what is written to their registers). Knowing the board it runs on, makes it much less likely to hit such a case.
>
> That's the exact reason why I have put DMI checks. I don't want people complaining on flashrom bricking/damaging someone's device and losing trust in this project.

To be effective, the DMI checks should happen as part of programmer initialisation. Looks like they do now, which is good.
> If we still want some possibility to probe the EC, aware of the risks, we could use the `force` flag from the CLI to forcefully send those commands under a warning that it may brick their device.

Sounds like a reasonable compromise.
> I am in favor of not breaking things wherever possible. Flashrom is not only an utility to change flash contents for hackers and developers right now (it probably was earlier). It is also used as a plugin in fwupd for example, where reliability and safety of the update is in the first place.

Definitely.