Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56825 )
Change subject: opaque_master: Use new API to register shutdown function
......................................................................
Patch Set 2:
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/56825/comment/14c6f488_ef2baa3a
PS1, Line 421: if (register_shutdown(linux_mtd_shutdown, (void *)data)) {
Yes right... I will update commit message. […]
Sorry for some delay. I tested this change on a device! linux_mtd finds a chip.
Updated commit message with what has been tested, and added more info to commit message.
Next thing I will do par masters.
And then, last thing is to go through edge cases and convert them to new API, one by one (raiden_debug, dummy, serprog, internal, ichspi).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8471a117556edcbf9694752fabe05cf4501ce70
Gerrit-Change-Number: 56825
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 23 Aug 2021 02:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment