Werner Zeh has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Patch Set 26: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/23203/20/fmap.c
File fmap.c:
https://review.coreboot.org/#/c/23203/20/fmap.c@256
PS20, Line 256: ret = 2;
: }
: }
:
: if (fmap_found)
: break;
: }
According to the man page: "If the area pointed to was moved, a free(ptr) is done. […]
OK, didn't know that. I need to use manpage more often.
Thanks for the info guys.
--
To view, visit
https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 26
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Oct 2018 04:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes