Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, eshankelkar@galorithm.com.
Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by eshankelkar@galorithm.com. ( https://review.coreboot.org/c/flashrom/+/71872?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by Nikolai Artemiev, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: ichspi.c: Bug fix for ich_hwseq_get_flash_id ......................................................................
ichspi.c: Bug fix for ich_hwseq_get_flash_id
In ich_hwseq_get_flash_id, flash_id_to_entry would return address of a structure present in flashchips array corresponding to provided manufacture_id and model_id. If this function returns NULL and if we don't return after printing the warning using msg_pwarn, we'll be dereferencing a NULL pointer, hence the return in that if is provided.
Change-Id: I35c112cd032e3b94e30c347766764392d5bbfe3d Signed-off-by: Eshan Kelkar eshangalorithm@gmail.com Signed-off-by: Anastasia Klimchuk aklm@flashrom.org --- M ichspi.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/71872/2