Change in flashrom[master]: programmer.h: Minor tidy up

[Nico Huber (Code Review)]

Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56466 )

Change subject: programmer.h: Minor tidy up
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> Very likely not in most cases. […]
> Hmmm, looking at this from another angle: I think we should just split the
> file. That would make guarding implicit, right? e.g. if you some code doesn't
> need USB stuff, it wouldn't include the usb header file.

If all these declarations can be clearly grouped, then I see no reason to have
them in a monolithic header file.

WDYT?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77
Gerrit-Change-Number: 56466
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Comment-Date: Fri, 30 Jul 2021 14:29:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: comment