Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2: Sorry for moving the file. This hits the comments
File doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/be29ed4a_7ce9fa9e PS1, Line 32: build
If this is a builddir (I think it is), then let's name it builddir. […]
Done
https://review.coreboot.org/c/flashrom/+/73359/comment/530722cc_64b5f42c PS1, Line 174: ross
ross -> cross (typo)
Done
https://review.coreboot.org/c/flashrom/+/73359/comment/ee143836_8c98b338 PS1, Line 192: If you are not happy with the initial configuration, e.g. a programmer is missing, : or you want to review it
If you want to change your initial configuration for some reason (for example you discovered that a […]
I've updated the description and there was also the <builddir> missing.
https://review.coreboot.org/c/flashrom/+/73359/comment/dfe4d714_a1bf81f8 PS1, Line 206: To get a code coverage report
For coverage report: let's keep the existing instructions, please! They more detailed, written recen […]
Ack
-
Thomas Heijligen (Code Review)