[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to bus master

[Thomas Heijligen (Code Review)]

Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine.

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )

Change subject: drivers: Move (un)map_flash_region from programmer to bus master
......................................................................

Patch Set 2:

(4 comments)

Patchset:

PS2: 
Moving the map/unmap functions out of the programmer_entry struct is a good thing. But Imo it then should go into the *_master struct, rather than into an extra struct, getting registered at the same time. If I got the code right, only par_masters, especially the par_master_internal, need to be able to map/unmap memory depending on the chip size. So for the long term it could be better to modify the chip probing such that a mapping function is only called on par_masters.

I'm open for anything that solves this problem sustainably.

File atapromise.c:

https://review.coreboot.org/c/flashrom/+/67695/comment/9f898b01_8a450771 
PS2, Line 133: atapromise_map
This may not be needed any longer, because `atapromise_map` has the same implementation as `fallback_map`. 
CB:67655

File atavia.c:

https://review.coreboot.org/c/flashrom/+/67695/comment/aaab064e_5191c399 
PS2, Line 147: atavia_map
This may also not be needed, CB:67656
But I have to test this on real hardware :/

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/67695/comment/1a71112e_d961e181 
PS2, Line 1865: &mapper_phys
I don't think mapping is used here. As far as I know it is only used for the par_master in internal.c

Nico, do you know more?