Change in flashrom[master]: util: Add Nix shell file - flashrom-gerrit

10 Oct 2021


      Attention is currently required from:  Felix Singer, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58012 )
Change subject: util: Add Nix shell file
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/shell.nix:
https://review.coreboot.org/c/flashrom/+/58012/comment/36be6811_369d361e 
PS3, Line 3: stdenv
Do I read this correctly?
...
Bash. This is the shell used for all builders in the Nix Packages collection. Not using /bin/sh removes a large source of portability problems.
It sounds like they encourage bashism?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50
Gerrit-Change-Number: 58012
Gerrit-PatchSet: 4
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 10 Oct 2021 16:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To:  Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment