Change in flashrom[master]: ich_descriptor.c: Simplify get_density lookups by deduplicate sw - flashrom-gerrit

11 May 2022


      Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63321 )
Change subject: ich_descriptor.c: Simplify get_density lookups by deduplicate sw
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/63321/comment/3041ec75_4bf8b126 
PS3, Line 167: static int get_density(enum ich_chipset cs, const struct ich_descriptors *desc, uint8_t idx, uint8_t *size_enc, uint8_t *size_max)
Can you provide information about the meaning of the return values?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63321
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4e9f19f4f06becd344fe08829dabe20c3c8de0
Gerrit-Change-Number: 63321
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 11 May 2022 15:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment