Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21828 )
Change subject: fixup! Convert flashrom to git ......................................................................
Patch Set 1:
Is there any automatic tool that checks for compliance? Or did anybody really check every line? How is adding this comment a fixup?
I agree to the full-stop, btw. Line could be broken too, though.
Is there any automatic tool that checks for compliance? Or did anybody really check every line? How is adding this comment a fixup?
I agree to the full-stop, btw. Line could be broken too, though.
This aspect was brought up during the initial review and so for me it naturally belongs to that change. I think we need to write down what fixup patches in the staging branch are supposed to be at some time... :)
Independent from the general issue with the staging process I really want to get the git commit "complete" so we have one definitive starting point for all commits to come. Unfortunately this was not possible with staging itself but it should definitely be for any stable release branch (I do intend to have a 0.9.9.1 with the most important fixes to ease getting them in LTS distributions). Hence I want to have such rather benign things in it if possible.
The comment in question documents intent to make this clear for reviewers as contributors (while the sh shebang should be a clear hint I think the comment is still warranted due to the local restriction and its outspokenness). There was no strict review for this I guess but a) I always intended it to be that way (but of course there might be bugs... e.g., I wasn't aware local is not POSIX before you brought it up), b) you had a look for that obviously in the first review.
-
Stefan Tauner (Code Review)