Attention is currently required from: Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71579 )
Change subject: programmer: Add pre-init hook ......................................................................
Patch Set 1:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71579/comment/be9e351b_4a6ca29d PS1, Line 164: Initialising
Very pedantic, buuut... […]
It would be really nice not to erase my language and history with Americanisation of the British language, I prefer not to use a z. flashrom needs a lot of grammatical work in any case.
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/71579/comment/5c1f3cb9_663b57e8 PS1, Line 51: struct programmer_cfg *cfg
The lack of `const` is intentional, right?
It is yes. I am going to mark these patches as WIP and put them in a topic. I was trying to deal with how internal requires board init first that mutates state so I was thinking the mutating part can be done in the pre phase. It is quite tricky how the code is.
-
Edward O'Callaghan (Code Review)