Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/8d558e4a_6c8952a7 PS4, Line 9: Include test for the dummy spi25 device.
If you could elaborate more on what this commit is doing, it would be great. […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/7ae0e13b_95194deb PS6, Line 9: Projects using libflashrom like fwupd expect the user to wait for the operation : to complete. To avoid the user thinking the process has "hung" or "got stuck" : report back the progress complete of the erase, write and read operations
That's good, thank you! One thing left, limit for commit message lines is 72 chars, look like this o […]
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/142391fb_52ee526d PS4, Line 113: private
private from the libflashrom API, as in "internal" to the flashrom implementation. […]
Resolving
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/7afa6a45_7abc905b PS5, Line 355: PAGE_SIZE
LSPCON_PAGE_SIZE ? commit cbe8a39ece4c228ffb23736da3f477ef3b82358c
Done
-
Daniel Campello (Code Review)