Attention is currently required from: Hsuan-ting Chen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79229?usp=email )
Change subject: erase_func_algo: Avoid putting 0xff into buffers ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1: Hsuan-ting, I appreciate your effort to create a patch, but I don't understand what is the issue you are trying to fix?
The test aims to run as close as possible to a real life scenario, and of course in real life there could be 0xff bytes in the chip memory. That's valid and should be tested and handled correctly by erase/write logic.
What do you mean by "ambiguous behavior"? The algorithm is deterministic, for a given state of memory on the chip and given image to write there is only one solution.
Maybe you can try explain the exact issue you are trying to fix, and I will try to help you?
-
Anastasia Klimchuk (Code Review)