Shiyu Sun has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/41021 )
Change subject: Makefile: Remove LSPCON_I2C_SPI dependency on libusb ......................................................................
Makefile: Remove LSPCON_I2C_SPI dependency on libusb
Turns out the LSPCON don't actually need libusb support.
BUG=b/155133607 BRANCH=none TEST=build and tested read/write/erase
Change-Id: I266b1a5fd9a0136495320509c7306fde18e64612 Signed-off-by: Shiyu Sun sshiyu@chromium.org --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/41021/1
diff --git a/Makefile b/Makefile index 31e987c..803529f 100644 --- a/Makefile +++ b/Makefile @@ -955,7 +955,6 @@ ifeq ($(CONFIG_LSPCON_I2C_SPI), yes) FEATURE_CFLAGS += -D'CONFIG_LSPCON_I2C_SPI=1' PROGRAMMER_OBJS += lspcon_i2c_spi.o -NEED_LIBUSB1 += CONFIG_LSPCON_I2C_SPI endif
ifeq ($(CONFIG_REALTEK_MST_I2C_SPI), yes)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41021 )
Change subject: Makefile: Remove LSPCON_I2C_SPI dependency on libusb ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/41021/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41021/1//COMMIT_MSG@9 PS1, Line 9: don't doesn’t
Shiyu Sun has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/41021 )
Change subject: Makefile: Remove LSPCON_I2C_SPI dependency on libusb ......................................................................
Abandoned
-
Paul Menzel (Code Review) -
Shiyu Sun (Code Review)