Change in flashrom[master]: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper - flashrom-gerrit

19 Apr 2021


      Attention is currently required from: Sam McNally, Peter Marheine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52405 )
Change subject: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper
......................................................................
Patch Set 6:
(2 comments)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52405/comment/3818f2ab_ddde4eb1 
PS6, Line 36: {
style nit: The opening brace for functions should go on the next line
https://review.coreboot.org/c/flashrom/+/52405/comment/56b0cd2b_fc1332b4 
PS6, Line 42: 	char *dev = malloc(sizeof(I2C_DEV_PREFIX));
This effectively undoes what CB:52415 did...
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52405
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieea57b2445f3aca16c87d8f839dff131009531a0
Gerrit-Change-Number: 52405
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 19 Apr 2021 08:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment