[S] Change in flashrom[master]: flashrom.c:Enable erase path optimisation - flashrom-gerrit

1 May 2023


      Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74872 )
Change subject: flashrom.c:Enable erase path optimisation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
This change breaks the unit test for full chip erase when write protect is enabled (https://ticket.coreboot.org/issues/488). I tracked the reason to be get_flash_region in flashrom.c:372 where flash->mst->spi.get_region has no value assigned so the final else block is being executed instead of the BUS_SPI one.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/74872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13e43b18b20dbb956b569e554953a19eb32ea22
Gerrit-Change-Number: 74872
Gerrit-PatchSet: 2
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 01 May 2023 13:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment