Change in ...flashrom[master]: chipset_enable: Mark Intel QS77 as DEP
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33164 Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... chipset_enable: Mark Intel QS77 as DEP Tested reading and writing with `-p internal` on MacBook Air 5,1 with Intel QS77. Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/33164/1 diff --git a/chipset_enable.c b/chipset_enable.c index 6280876..19fd658 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1746,7 +1746,7 @@ {0x8086, 0x1e4a, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, NT, "Intel", "C216", enable_flash_pch7}, {0x8086, 0x1e55, DEP, "Intel", "QM77", enable_flash_pch7}, - {0x8086, 0x1e56, NT, "Intel", "QS77", enable_flash_pch7}, + {0x8086, 0x1e56, DEP, "Intel", "QS77", enable_flash_pch7}, {0x8086, 0x1e57, DEP, "Intel", "HM77", enable_flash_pch7}, {0x8086, 0x1e58, NT, "Intel", "UM77", enable_flash_pch7}, {0x8086, 0x1e59, NT, "Intel", "HM76", enable_flash_pch7}, -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-MessageType: newchange
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/33164 to look at the new patch set (#2). Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... chipset_enable: Mark Intel QS77 as DEP Tested reading and writing with `-p internal` on MacBook Air 5,2 with Intel QS77. Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/33164/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33164 ) Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 03 Jun 2019 10:51:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/flashrom/+/33164 ) Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... Removed reviewer build bot (Jenkins) with the following votes: * Verified+1 by build bot (Jenkins) <no-reply@coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: deleteReviewer
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33164 ) Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... chipset_enable: Mark Intel QS77 as DEP Tested reading and writing with `-p internal` on MacBook Air 5,2 with Intel QS77. Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Signed-off-by: Evgeny Zinoviev <me@ch1p.io> Reviewed-on: https://review.coreboot.org/c/flashrom/+/33164 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 6280876..19fd658 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1746,7 +1746,7 @@ {0x8086, 0x1e4a, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, NT, "Intel", "C216", enable_flash_pch7}, {0x8086, 0x1e55, DEP, "Intel", "QM77", enable_flash_pch7}, - {0x8086, 0x1e56, NT, "Intel", "QS77", enable_flash_pch7}, + {0x8086, 0x1e56, DEP, "Intel", "QS77", enable_flash_pch7}, {0x8086, 0x1e57, DEP, "Intel", "HM77", enable_flash_pch7}, {0x8086, 0x1e58, NT, "Intel", "UM77", enable_flash_pch7}, {0x8086, 0x1e59, NT, "Intel", "HM76", enable_flash_pch7}, -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (2)
-
Evgeny Zinoviev (Code Review) -
Nico Huber (Code Review)