Attention is currently required from: Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69267 )
Change subject: tests: Detect llvm coverage file io and unmock io functions ......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69267/comment/7568c980_4b8aeb95 PS6, Line 9: atexit
missing space: atexit -> at exit
Done
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/69267/comment/b66f134c_204efe9a PS3, Line 140: if (!check_suffix(pathname, ".gcda") || !check_suffix(pathname, ".profraw"))
strangely llvm uses fopen in my ubuntu, but uses open in chromeos. […]
Done
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/69267/comment/c08f7d15_0881e5b6 PS6, Line 234: // We detect code coverage writing the log files and defer to real io functions. : if (!check_suffix(pathname, ".gcda") || !check_suffix(pathname, ".profraw")) : io_mock_register(&real_io_mock);
Is this code needed for __wrap_fopen64?
Done