Attention is currently required from: Sam McNally, Anastasia Klimchuk, Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71659 )
Change subject: tests/chip: Add non-aligned write within a region unit-test
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71659/comment/2ce4f567_3a9e82c8
PS2, Line 7: tests/: Add subregion alignment unit-test
What does non-aligned mean? The commit message can match the test name
https://github.com/flashrom/flashrom/blob/master/flashrom.c#L1426
everything renamed to be consistent with the term "non-aligned"
--
To view, visit
https://review.coreboot.org/c/flashrom/+/71659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id3ce5cd1936f0f348d34a6c77cee15e27a5c353f
Gerrit-Change-Number: 71659
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Evan Benn
evanbenn@google.com
Gerrit-Comment-Date: Thu, 12 Jan 2023 02:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment