Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66211 )
Change subject: spi25_statusreg: support reading/writing configuration register
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS2:
Rebased everything due to `flashchips. […]
After reading all the comments, and also given the +2, and given the CB:69399 at the end of a chain: it does seem to me that all comment threads can be marked resolved?
If I am wrong please tell me.
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66211/comment/afef960e_f35ffa38
PS5, Line 189: /* For chips that call SR2 "Configuration Register 1" */
: #define CONFIG1 STATUS2
: /* For chips that call SR3 "Configuration Register 2" */
: #define CONFIG2 STATUS3
Is it instead a good idea to add these as new values to the `flash_reg` enum and separately switch o […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66211
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45f9afcc31f1928ef6263a749596380082963de4
Gerrit-Change-Number: 66211
Gerrit-PatchSet: 8
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 23:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment