Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev.
Hello Felix Singer, build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67695
to look at the new patch set (#10).
Change subject: drivers: Move (un)map_flash_region to par/spi/opaque_master ......................................................................
drivers: Move (un)map_flash_region to par/spi/opaque_master
Move (un)map_flash_region function pointers from programmer_entry to par_master, spi_master, and opaque_master. This enables programmers to specify a different mapper per bus, which is needed for the internal programmer. Mapping is closely tied to the way the memory is accessed using the other functions in the bus master structs.
Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses.
programmer.c: Update comment in fallback_map(), NULL return is the desired behavior.
Test: Read firmware on SB600 Promontory mainboard (requires physmap) Test: Read firmware externally with ft2232_spi Test: Read firmware on ICH hwseq, verify physmap still occurs
Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall jonathon.hall@puri.sm Co-Authored-by: Edward O'Callaghan quasisec@google.com --- M atavia.c M dummyflasher.c M flashrom.c M ichspi.c M include/flash.h M include/programmer.h M internal.c M it87spi.c M parallel.c M programmer.c M sb600spi.c M serprog.c M wbsio_spi.c 13 files changed, 147 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/10