Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52365 )
Change subject: flashrom.c: Fix up stale FIXME comment when doit() was removed ......................................................................
flashrom.c: Fix up stale FIXME comment when doit() was removed
Once upon a time flashrom had a entry point function called doit(). Excise the last mention of it here so that we may never mention it again.
BUG=none TEST=none
Change-Id: I40d815b7154456c323b4230cd3fed2cc2e8e3641 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/52365 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M flashrom.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, but someone else must approve
diff --git a/flashrom.c b/flashrom.c index c89abad..056fc57 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2189,8 +2189,8 @@ return ret; }
-/* FIXME: This function signature needs to be improved once doit() has a better - * function signature. +/* FIXME: This function signature needs to be improved once prepare_flash_access() + * has a better function signature. */ static int chip_safety_check(const struct flashctx *flash, int force, int read_it, int write_it, int erase_it, int verify_it)