Change in flashrom[master]: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset - flashrom-gerrit

11 Apr 2022


      Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63470 )
Change subject: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1: 
Changes
  print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "HSFC", (reg_val & (0xf << (17 - 16))) >> (17 - 16));
to
  print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "FCYCLE", (reg_val & (0xf << (17 - 16))) >> (17 - 16));
which actually fixes it. No idea what I originally intended with
the `_pprint_reg` macro. I guess we can/should drop it now.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5a8d84639b7226bf82458a7310f306c5232cffe3
Gerrit-Change-Number: 63470
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 11:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment