Change in flashrom[master]: flashrom_tester: Use elogtool to list firmware eventlog - flashrom-gerrit

24 Oct 2021


      Attention is currently required from: Furquan Shaikh, Jack Rosenthal.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58527 )
Change subject: flashrom_tester: Use elogtool to list firmware eventlog
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/flashrom_tester/src/cros_sysinfo.rs:
https://review.coreboot.org/c/flashrom/+/58527/comment/1dc75c3c_f9905785 
PS2, Line 70: "/usr/bin/elogtool"
...
Idea: Put this path in a constant to avoid repeating it here and in the log message above?
Jack, thanks for the patch and sending to upstream first!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58527
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c4be82fed28b6a19746e6b93fafce23bd8ede5d
Gerrit-Change-Number: 58527
Gerrit-PatchSet: 2
Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Ricardo Quesada ricardoq@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Jack Rosenthal jrosenth@chromium.org
Gerrit-Comment-Date: Sun, 24 Oct 2021 23:58:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment