Attention is currently required from: Felix Singer, Angel Pons. WereCatf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58134 )
Change subject: flashchips: Add Puya P25Q21H/11H/06H ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58134/comment/749dae56_fbfa9f8b PS2, Line 10: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf
While we're at it, I'd greatly appreciate if you could add support for the P25Q11H and P25Q06H as we […]
Done
Patchset:
PS3: Requested changes made.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58134/comment/d56bd9b9_f640bc0b PS2, Line 13158: }, {
Missing entries for the full chip erase commands: […]
Done
https://review.coreboot.org/c/flashrom/+/58134/comment/cc69cdb7_829d2966 PS2, Line 13158: : .eraseblocks = { {256, 1024} }, : .block_erase = spi_block_erase_81
Block eraser entries should be sorted in ascending block size (the pair of numbers is `{ block size, […]
Done
https://review.coreboot.org/c/flashrom/+/58134/comment/44b2bd1d_216d4e58 PS2, Line 13163: spi_prettyprint_status_register_plain
spi_prettyprint_status_register_bp4_srwd
Done
https://review.coreboot.org/c/flashrom/+/58134/comment/f3c102e1_6fcbe5d0 PS2, Line 13164: spi_disable_blockprotect
spi_disable_blockprotect_bp4_srwd
Done
-
WereCatf (Code Review)