Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66211 )
Change subject: spi25_statusreg: support reading/writing configuration register
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS2:
Rebased everything due to `flashchips.c` changes and moved aliasing to CB:69399 restoring an older patchset here.
it seemed to make the code simpler
I guess it depends on how you look at it. Aliasing does make SPI code changes smaller and keeps fewer entities to know about, but I think Edward's argument is that not using aliasing makes understanding and modifying code easier, because it has more obvious structure.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66211
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45f9afcc31f1928ef6263a749596380082963de4
Gerrit-Change-Number: 66211
Gerrit-PatchSet: 8
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Nov 2022 17:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment