Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60272 )
Change subject: ichspi: Remove unneeded line breaks, add useful ones ......................................................................
Patch Set 2:
(6 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/60272/comment/5b093da4_69c140e6 PS1, Line 930: REGREAD16(ICH7_REG_SPIS)); This too
https://review.coreboot.org/c/flashrom/+/60272/comment/46028a97_5e831f84 PS1, Line 999: SSFC_DBC); I would remove this line break.
https://review.coreboot.org/c/flashrom/+/60272/comment/14cbee9a_de8cea28 PS1, Line 1052: REGREAD32(swseq_data.reg_ssfsc)); This too
https://review.coreboot.org/c/flashrom/+/60272/comment/3097ac95_b252a912 PS1, Line 1127: cmd); This too
https://review.coreboot.org/c/flashrom/+/60272/comment/c991f56e_80a412c1 PS1, Line 1402: "N This too
https://review.coreboot.org/c/flashrom/+/60272/comment/68270b8c_a8652b73 PS1, Line 1720:
Looking at the rest of the file, there are more. So it seems to be intended, but still weird.
Ah! I think I understand this now. This is an extension so that the contents in these brackets are on the same character level. Well. Sorry for the noise :) Done.
-
Felix Singer (Code Review)