Attention is currently required from: Idwer Vollering, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63612 )
Change subject: platform.h: rename swapX to ___swapX
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Hmmm, I remember reading something about names starting with underscores being special in the C spec. Could we use names that begin with something else instead?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04d73967f694939c1127f48df8645a10e9dd66f3
Gerrit-Change-Number: 63612
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 13 Apr 2022 13:18:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment