Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen, Victor Lim.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82197?usp=email )
Change subject: doc: Add doc for supported flash chips ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS1:
The old page is here: https://wiki.flashrom.org/Supported_hardware#Supported_flash_chips […]
Yeah, great idea! As far as I can see last time it was updated in 2013! More than 10 years ago...
But having a table of supported hardware is really handy. I think it makes sense to spend time on finding any built-in methods in sphinx that can help us maintain a table in this document instead of the wiki.
File doc/supported_hw/supported_flashchips.rst:
https://review.coreboot.org/c/flashrom/+/82197/comment/24a35ed4_872eb23b : PS2, Line 12: Alternatively inspect the file on the `web UI of our GitHub mirror https://github.com/flashrom/flashrom/blob/main/flashchips.c`_. I would suggest moving this paragraph to the first one, because they're logically related
https://review.coreboot.org/c/flashrom/+/82197/comment/20b1798b_115ac143 : PS2, Line 14: If you want to check whether a flash chip is supported in the given release, you can rebase your local : repo at the release tag, alternatively select a tag/branch in GitHub web UI (dropdown on the top-left). It doesn't sound like a really user-friendly method to check whether a desired flash chip is supported :(
Can we maintain a list of supported chips for a specific release as a text file? Looks like we have to add it to the upcoming agenda :D
https://review.coreboot.org/c/flashrom/+/82197/comment/72490d88_8e7bc1d2 : PS2, Line 23: Instructions how to update tested status of the chip are here: :doc:`/contrib_howtos/how_to_mark_chip_tested`. : : Instructions how to add support for a chip are here: :doc:`/contrib_howtos/how_to_add_new_chip`. How about just adding them as a "related topics" list?