Attention is currently required from: Anastasia Klimchuk.
Peter Marheine has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_classic: Add rpmc command support ......................................................................
Patch Set 4:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84840/comment/fdf5ab80_6c77bc8b?usp... : PS4, Line 1323: if (options.rpmc_read_data) : ret = rpmc_read_data(fill_flash);
I agree I think the stuff from rpmc.c should rather be in libflashrom. […]
Making it API-friendly sounds good, but I would hold off on adding this support to the public API since it would be difficult to make backward-compatible changes if we find issues.
-
Peter Marheine (Code Review)