Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices

[Hung-Te Lin (Code Review)]

Attention is currently required from: Nico Huber, Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 )

Change subject: linux_mtd: Switch fopen() to open() for MTD devices
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> You only included half the comment, though!

Yes I saw the fixme and considered "not all MTD drivers handle arbitrary large reads well." as the unexpected behavior.
> I guess it was the chunking that was important not the alignment but the two were conflated in the comment.

I looked at the history and found things interesting.

- The implementation was using read/write in the beginning, and was changed by https://chromium-review.googlesource.com/2310521 (b/153598951) - to sync with upstream.
- The chunk was implemented on https://chromium-review.googlesource.com/505409/ (b/35573113) and yes, from there alignment is not important.

So yes, staying with libc is probably the right way.